How to submit patches - Revision history

Rppt at 10:27, 17 March 2020

2020-03-17T10:27:20Z

2020-01-29T09:35:02Z

Mail patches

2019-01-04T18:31:53Z

Make a patch: Fix git send-email example to use "criu-dev" instead of "master" branch

2018-09-13T17:02:45Z

Make a patch

2018-09-13T17:02:01Z

Make a patch

2018-09-13T16:25:39Z

Make a patch: Add git send-email instructions

2018-03-30T18:21:34Z

Test your changes

2018-01-20T15:35:58Z

Update coding style link

2017-09-28T07:38:32Z

2017-03-22T00:23:15Z

Continuous integration: expand, add links. Fix examples formatting

@@ Line 36: / Line 36: @@
 * we prefer tabs and indentations to be 8 characters width
-* consider reading [https://www.kernel.org/doc/Documentation/process/coding-style.rst Linux kernel coding style].
+* CRIU mostly follows [https://www.kernel.org/doc/Documentation/process/coding-style.rst Linux kernel coding style], but we are less strict than the kernel community.
 Other conventions can be learned from the source code itself. In short, make sure your new code
@@ Line 53: / Line 53: @@
 as well as run most of the tests from the suite. See https://travis-ci.org/checkpoint-restore/criu
 for more details.
 == Sign your work ==
@@ Line 156: / Line 117: @@
 </div></div>
-== Mail patches ==
+== Submit your work upstream ==
 The patches should be sent to CRIU development mailing list, <code>criu AT openvz.org</code>. Note that you need to be subscribed first in order to post. The list web interface is available at https://openvz.org/mailman/listinfo/criu; you can also use standard mailman aliases to work with it.
@@ Line 164: / Line 171: @@
 {{Note| When sending a patch set that consists of more than one patch, please, push your changes in your local repo and provide the URL of the branch in the cover-letter}}
-== Wait for response ==
+=== Wait for response ===
 Be patient. Most CRIU developers are pretty busy people so if

← Older revision		Revision as of 09:35, 29 January 2020
Line 161:		Line 161:

	Please make sure the email client you're using doesn't screw your patch (line wrapping and so on).		Please make sure the email client you're using doesn't screw your patch (line wrapping and so on).
		+
		+	{{Note\| When sending a patch set that consists of more than one patch, please, push your changes in your local repo and provide the URL of the branch in the cover-letter}}

	== Wait for response ==		== Wait for response ==

@@ Line 68: / Line 68: @@
    git send-email --cover-letter --no-chain-reply-to --annotate \
-                  --confirm=always --to=criu@openvz.org master
+                  --confirm=always --to=criu@openvz.org criu-dev
 Note that the <code>git send-email</code> subcommand may not be in

@@ Line 58: / Line 58: @@
 To create a patch, run
-     git format-patch origin/criu-dev
+     git format-patch --signoff origin/criu-dev
 You might need to read GIT documentation on how to prepare patches

@@ Line 58: / Line 58: @@
 To create a patch, run
-     git format-patch
+     git format-patch origin/criu-dev
 You might need to read GIT documentation on how to prepare patches

@@ Line 51: / Line 51: @@
 In case you'd rather have someone else run the tests, you can use travis-ci for your
 own github fork of CRIU. It will check the compilation for various supported platforms,
-as well as run most of the tests from the suite. See https://travis-ci.org/xemul/criu
+as well as run most of the tests from the suite. See https://travis-ci.org/checkpoint-restore/criu
 for more details.

@@ Line 5: / Line 5: @@
 == Get the source code ==
-The CRIU sources are tracked by Git. Official CRIU repo is at [https://github.com/xemul/criu https://github.com/xemul/criu].
+The CRIU sources are tracked by Git. Official CRIU repo is at [https://github.com/checkpoint-restore/criu https://github.com/checkpoint-restore/criu].
 The repository may contain multiple branches. Development happens in the '''criu-dev''' branch.
@@ Line 12: / Line 12: @@
 <pre><nowiki>
-         git clone https://github.com/xemul/criu criu
+         git clone https://github.com/checkpoint-restore/criu criu
          cd criu
          git checkout criu-dev

@@ Line 11: / Line 11: @@
 To clone CRIU repo and switch to the proper branch, run:
-<source>
+<pre><nowiki>
-git clone https://github.com/xemul/criu criu
+        git clone https://github.com/xemul/criu criu
-cd criu
+        cd criu
-git checkout criu-dev
+        git checkout criu-dev
-</source>
+</nowiki></pre>
 == Compile ==
@@ Line 23: / Line 23: @@
 To compile CRIU, run:
-<source>make</source>
+        make
 This should create the <code>./criu/criu</code> executable.
@@ Line 75: / Line 75: @@
 can certify the below:
-<div class="toccolours mw-collapsible mw-collapsed" style="width: 64em;">
+<div class="toccolours mw-collapsible mw-collapsed" style="width: 46em;">
 '''Developer's Certificate of Origin 1.1'''
 <div class="mw-collapsible-content">
@@ Line 113: / Line 113: @@
 <code>git commit --amend -s</code>.
-<div class="toccolours mw-collapsible mw-collapsed" style="width: 64em;">
+<div class="toccolours mw-collapsible mw-collapsed" style="width: 46em;">
 '''Example patch message'''
 <div class="mw-collapsible-content">
@@ Line 140: / Line 140: @@
 sometimes a patch may fly around a week before it gets reviewed.
-== Continuous Integration ==
+== Continuous integration ==
-CRIU tests are run for each series. If you get a message from our patchwork that patches haven't pass tests, you have to investigate what is wrong. We recommend to use  https://travis-ci.org/ to check patches before sending them into the mailing list.
 [[Category:Development]]